diff options
| author | Huazhong Tan <tanhuazhong@huawei.com> | 2018-12-18 19:37:48 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-12-18 12:01:00 -0800 |
| commit | cda69d244585bc4497d3bb878c22fe2b6ad647c1 (patch) | |
| tree | 903f131c4137f8c608615cec87ea42198dcfa7dd | |
| parent | 77c7a7b3e7da2c97c182c7e57a16d16c6b555c24 (diff) | |
| download | linux-cda69d244585bc4497d3bb878c22fe2b6ad647c1.tar.gz linux-cda69d244585bc4497d3bb878c22fe2b6ad647c1.tar.bz2 linux-cda69d244585bc4497d3bb878c22fe2b6ad647c1.zip | |
net: hns3: fix error handling int the hns3_get_vector_ring_chain
When hns3_get_vector_ring_chain() failed in the
hns3_nic_init_vector_data(), it should do the error handling instead
of return directly.
Also, cur_chain should be freed instead of chain and head->next should
be set to NULL in error handling of hns3_get_vector_ring_chain.
This patch fixes them.
Fixes: 73b907a083b8 ("net: hns3: bugfix for buffer not free problem during resetting")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 69142a381064..2081e2eb18fd 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2993,9 +2993,10 @@ err_free_chain: cur_chain = head->next; while (cur_chain) { chain = cur_chain->next; - devm_kfree(&pdev->dev, chain); + devm_kfree(&pdev->dev, cur_chain); cur_chain = chain; } + head->next = NULL; return -ENOMEM; } @@ -3086,7 +3087,7 @@ static int hns3_nic_init_vector_data(struct hns3_nic_priv *priv) ret = hns3_get_vector_ring_chain(tqp_vector, &vector_ring_chain); if (ret) - return ret; + goto map_ring_fail; ret = h->ae_algo->ops->map_ring_to_vector(h, tqp_vector->vector_irq, &vector_ring_chain); |