diff options
| author | Codrin Ciubotariu <codrin.ciubotariu@microchip.com> | 2019-06-25 12:10:02 +0300 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2019-07-22 14:32:08 -0700 |
| commit | 1573eebeaa8055777eb753f9b4d1cbe653380c38 (patch) | |
| tree | 6caafce6cc4df9eb416751a10caac89ef88d2b97 | |
| parent | 5f9e832c137075045d15cd6899ab0505cfb2ca4b (diff) | |
| download | linux-1573eebeaa8055777eb753f9b4d1cbe653380c38.tar.gz linux-1573eebeaa8055777eb753f9b4d1cbe653380c38.tar.bz2 linux-1573eebeaa8055777eb753f9b4d1cbe653380c38.zip | |
clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
In clk_generated_determine_rate(), if the divisor is greater than
GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
If clk_generated_set_rate() will be called later with this wrong
rate, it will return -EINVAL, so the generated clock won't change
its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/at91/clk-generated.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c index 44db83a6d01c..44a46dcc0518 100644 --- a/drivers/clk/at91/clk-generated.c +++ b/drivers/clk/at91/clk-generated.c @@ -141,6 +141,8 @@ static int clk_generated_determine_rate(struct clk_hw *hw, continue; div = DIV_ROUND_CLOSEST(parent_rate, req->rate); + if (div > GENERATED_MAX_DIV + 1) + div = GENERATED_MAX_DIV + 1; clk_generated_best_diff(req, parent, parent_rate, div, &best_diff, &best_rate); |