diff options
| author | Himanshu Jha <himanshujha199640@gmail.com> | 2017-09-12 16:49:22 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-09-15 14:02:05 -0700 |
| commit | 4739df6211911e6597602222b640e5c002563df6 (patch) | |
| tree | 03274c94676b8172c3f96dcd6df821454c78561b | |
| parent | 23f4822207e04c5f78924fe0e5193c14ba720b4c (diff) | |
| download | linux-4739df6211911e6597602222b640e5c002563df6.tar.gz linux-4739df6211911e6597602222b640e5c002563df6.tar.bz2 linux-4739df6211911e6597602222b640e5c002563df6.zip | |
qed: remove unnecessary call to memset
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.
Semantic patch used to resolve this issue:
@@
expression e,e2; constant c;
statement S;
@@
e = kzalloc(e2, c);
if(e == NULL) S
- memset(e, 0, e2);
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Sudarsana Kalluru <sudarsana.kalluru@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index eaca4578435d..8f6ccc0c39e5 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn, if (!dcbx_info) return -ENOMEM; - memset(dcbx_info, 0, sizeof(*dcbx_info)); rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB); if (rc) { kfree(dcbx_info); |