diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2019-04-03 10:56:33 -0700 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2019-04-10 16:33:48 -0500 |
| commit | af3be70a32113787da9f15e4ce8a357ae6caa293 (patch) | |
| tree | aea9bef4c73b39fa7d7235c2437a01f6ed824bbf | |
| parent | 12eeae7147af32f7d3bbf0f1753313f88b8ce97b (diff) | |
| download | linux-af3be70a32113787da9f15e4ce8a357ae6caa293.tar.gz linux-af3be70a32113787da9f15e4ce8a357ae6caa293.tar.bz2 linux-af3be70a32113787da9f15e4ce8a357ae6caa293.zip | |
of: Improve of_phandle_iterator_next() error message
Understanding why of_phandle_iterator_next() returns an error can
sometimes be hard to decipher based solely on the error message, a
typical error example is that #foo-cells = <X> and the phandle property
used has a smaller number of cells specified, e.g.:
#thermal-sensor-cells = <1>;
phandle = <&scmi_sensor>
instead of:
phandle <&scmi_sensor 0>;
Instead, make it clear what the expectations are towards debugging
incorrect Device Tree faster:
OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/of/base.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c index 5226e898476e..20e0e7ee4edf 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1350,8 +1350,9 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it) * property data length */ if (it->cur + count > it->list_end) { - pr_err("%pOF: arguments longer than property\n", - it->parent); + pr_err("%pOF: %s = %d found %d\n", + it->parent, it->cells_name, + count, it->cell_count); goto err; } } |