summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYueHaibing <yuehaibing@huawei.com>2018-08-07 21:02:34 +0800
committerIlya Dryomov <idryomov@gmail.com>2018-08-13 17:55:44 +0200
commitbad87216fb8426302cd53a5fcfdd45c3a5d54383 (patch)
tree64df31bbe2e7894b4f42d963949038c513bce21e
parente5bc08d09f5fac5cd2901f34b510e67c524894ab (diff)
downloadlinux-bad87216fb8426302cd53a5fcfdd45c3a5d54383.tar.gz
linux-bad87216fb8426302cd53a5fcfdd45c3a5d54383.tar.bz2
linux-bad87216fb8426302cd53a5fcfdd45c3a5d54383.zip
libceph: remove unnecessary non NULL check for request_key
request_key never return NULL,so no need do non-NULL check. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
-rw-r--r--net/ceph/ceph_common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c
index 6ebd7d953ee0..87afb9ec4c68 100644
--- a/net/ceph/ceph_common.c
+++ b/net/ceph/ceph_common.c
@@ -304,7 +304,7 @@ static int get_secret(struct ceph_crypto_key *dst, const char *name) {
struct ceph_crypto_key *ckey;
ukey = request_key(&key_type_ceph, name, NULL);
- if (!ukey || IS_ERR(ukey)) {
+ if (IS_ERR(ukey)) {
/* request_key errors don't map nicely to mount(2)
errors; don't even try, but still printk */
key_err = PTR_ERR(ukey);