diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2014-08-07 14:07:42 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-08-16 17:14:30 -0500 |
| commit | a5e7c719fe257214aeda3dadb502a4cf58209a61 (patch) | |
| tree | d057d3f23c235bab199b4ec9010d79faf6336403 | |
| parent | a6be4de6a24cbef6209e3a0fcddaee9e312a1f63 (diff) | |
| download | linux-a5e7c719fe257214aeda3dadb502a4cf58209a61.tar.gz linux-a5e7c719fe257214aeda3dadb502a4cf58209a61.tar.bz2 linux-a5e7c719fe257214aeda3dadb502a4cf58209a61.zip | |
spi: sh-msiof: Return early in sh_msiof_dma_once() where possible
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
| -rw-r--r-- | drivers/spi/spi-sh-msiof.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index 811a42dba92a..daaa868e959f 100644 --- a/drivers/spi/spi-sh-msiof.c +++ b/drivers/spi/spi-sh-msiof.c @@ -642,18 +642,14 @@ static int sh_msiof_dma_once(struct sh_msiof_spi_priv *p, const void *tx, desc_rx = dmaengine_prep_slave_single(p->master->dma_rx, p->rx_dma_addr, len, DMA_FROM_DEVICE, DMA_PREP_INTERRUPT | DMA_CTRL_ACK); - if (!desc_rx) { - ret = -EAGAIN; - goto no_dma_rx; - } + if (!desc_rx) + return -EAGAIN; desc_rx->callback = sh_msiof_dma_complete; desc_rx->callback_param = p; cookie = dmaengine_submit(desc_rx); - if (dma_submit_error(cookie)) { - ret = cookie; - goto no_dma_rx; - } + if (dma_submit_error(cookie)) + return cookie; } if (tx) { @@ -738,7 +734,6 @@ no_dma_tx: if (rx) dmaengine_terminate_all(p->master->dma_rx); sh_msiof_write(p, IER, 0); -no_dma_rx: return ret; } |