diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2019-02-23 14:20:40 +0100 |
---|---|---|
committer | Kevin Hilman <khilman@baylibre.com> | 2019-03-18 09:07:32 -0700 |
commit | fdda0a6adc33536ad468f07db27325423703c5bc (patch) | |
tree | 0318f79b3b10495d43486747b451a6bd3b913920 | |
parent | 65f80df58eb770b2b687c35142c113d1ad6fa415 (diff) | |
download | linux-fdda0a6adc33536ad468f07db27325423703c5bc.tar.gz linux-fdda0a6adc33536ad468f07db27325423703c5bc.tar.bz2 linux-fdda0a6adc33536ad468f07db27325423703c5bc.zip |
meson-gx-socinfo: add missing of_node_put after of_device_is_available
Add an of_node_put when a tested device node is not available.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@
e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>
Fixes: a9daaba2965e8 ("soc: Add Amlogic SoC Information driver")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
-rw-r--r-- | drivers/soc/amlogic/meson-gx-socinfo.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c index c8d138d85f34..bca34954518e 100644 --- a/drivers/soc/amlogic/meson-gx-socinfo.c +++ b/drivers/soc/amlogic/meson-gx-socinfo.c @@ -132,8 +132,10 @@ static int __init meson_gx_socinfo_init(void) return -ENODEV; /* check if interface is enabled */ - if (!of_device_is_available(np)) + if (!of_device_is_available(np)) { + of_node_put(np); return -ENODEV; + } /* check if chip-id is available */ if (!of_property_read_bool(np, "amlogic,has-chip-id")) |