diff options
| author | liaoweixiong <liaoweixiong@allwinnertech.com> | 2019-06-28 12:14:46 +0800 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2019-06-28 09:34:12 +0200 |
| commit | b83408b580eccf8d2797cd6cb9ae42c2a28656a7 (patch) | |
| tree | acb8c111ce481a00ff52adbdba2542f4b28040d1 | |
| parent | 3552691616c940a7c4125c2678ba816653cd725e (diff) | |
| download | linux-b83408b580eccf8d2797cd6cb9ae42c2a28656a7.tar.gz linux-b83408b580eccf8d2797cd6cb9ae42c2a28656a7.tar.bz2 linux-b83408b580eccf8d2797cd6cb9ae42c2a28656a7.zip | |
mtd: spinand: read returns badly if the last page has bitflips
In case of the last page containing bitflips (ret > 0),
spinand_mtd_read() will return that number of bitflips for the last
page while it should instead return max_bitflips like it does when the
last page read returns with 0.
Signed-off-by: Weixiong Liao <liaoweixiong@allwinnertech.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: stable@vger.kernel.org
Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
| -rw-r--r-- | drivers/mtd/nand/spi/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index f0f3528aab8f..89f6beefb01c 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, if (ret == -EBADMSG) { ecc_failed = true; mtd->ecc_stats.failed++; - ret = 0; } else { mtd->ecc_stats.corrected += ret; max_bitflips = max_t(unsigned int, max_bitflips, ret); } + ret = 0; ops->retlen += iter.req.datalen; ops->oobretlen += iter.req.ooblen; } |