diff options
| author | Johan Hovold <jhovold@gmail.com> | 2014-03-12 19:09:39 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2014-03-12 12:44:49 -0700 |
| commit | fc11efe2800f2f9ba2ccb268321642b7e9f73a65 (patch) | |
| tree | 9637222cfe2a617baaf7e64956c3374e2c192b9c | |
| parent | 5083fd7bdfe6760577235a724cf6dccae13652c2 (diff) | |
| download | linux-fc11efe2800f2f9ba2ccb268321642b7e9f73a65.tar.gz linux-fc11efe2800f2f9ba2ccb268321642b7e9f73a65.tar.bz2 linux-fc11efe2800f2f9ba2ccb268321642b7e9f73a65.zip | |
USB: serial: continue to read on errors
Make sure to try to resubmit the read urb on errors.
Currently a recoverable error would lead to reduced throughput as only
one urb will be used until the port is closed and reopened (or
resumed or unthrottled).
Also upgrade error messages from debug to error log level.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
| -rw-r--r-- | drivers/usb/serial/generic.c | 21 |
1 files changed, 17 insertions, 4 deletions
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index b63ce023f96f..d7f39ea7d6ac 100644 --- a/drivers/usb/serial/generic.c +++ b/drivers/usb/serial/generic.c @@ -359,16 +359,29 @@ void usb_serial_generic_read_bulk_callback(struct urb *urb) dev_dbg(&port->dev, "%s - urb %d, len %d\n", __func__, i, urb->actual_length); - - if (urb->status) { - dev_dbg(&port->dev, "%s - non-zero urb status: %d\n", - __func__, urb->status); + switch (urb->status) { + case 0: + break; + case -ENOENT: + case -ECONNRESET: + case -ESHUTDOWN: + dev_dbg(&port->dev, "%s - urb stopped: %d\n", + __func__, urb->status); + return; + case -EPIPE: + dev_err(&port->dev, "%s - urb stopped: %d\n", + __func__, urb->status); return; + default: + dev_err(&port->dev, "%s - nonzero urb status: %d\n", + __func__, urb->status); + goto resubmit; } usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data); port->serial->type->process_read_urb(urb); +resubmit: /* Throttle the device if requested by tty */ spin_lock_irqsave(&port->lock, flags); port->throttled = port->throttle_req; |