summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>2019-04-12 19:52:36 +0900
committerDavid S. Miller <davem@davemloft.net>2019-04-12 10:25:03 -0700
commit238ffdc49ef98b15819cfd5e3fb23194e3ea3d39 (patch)
tree6c23048270495971ca7ab13423d5ca7df6d00786
parentdd3ac9a684358b8c1d5c432ca8322aaf5e4f28ee (diff)
downloadlinux-238ffdc49ef98b15819cfd5e3fb23194e3ea3d39.tar.gz
linux-238ffdc49ef98b15819cfd5e3fb23194e3ea3d39.tar.bz2
linux-238ffdc49ef98b15819cfd5e3fb23194e3ea3d39.zip
mISDN: Check address length before reading address family
KMSAN will complain if valid address length passed to bind() is shorter than sizeof("struct sockaddr_mISDN"->family) bytes. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/mISDN/socket.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c
index 4ab8b1b6608f..a14e35d40538 100644
--- a/drivers/isdn/mISDN/socket.c
+++ b/drivers/isdn/mISDN/socket.c
@@ -710,10 +710,10 @@ base_sock_bind(struct socket *sock, struct sockaddr *addr, int addr_len)
struct sock *sk = sock->sk;
int err = 0;
- if (!maddr || maddr->family != AF_ISDN)
+ if (addr_len < sizeof(struct sockaddr_mISDN))
return -EINVAL;
- if (addr_len < sizeof(struct sockaddr_mISDN))
+ if (!maddr || maddr->family != AF_ISDN)
return -EINVAL;
lock_sock(sk);