diff options
| author | Eric Dumazet <edumazet@google.com> | 2022-05-09 20:57:40 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-05-11 12:44:16 +0100 |
| commit | d7ea0d9df2a6265b2b180d17ebc64b38105968fc (patch) | |
| tree | e0e068df46a8e60e53a0670a8846f801cc613154 | |
| parent | 66e4c8d950083df8e12981babca788e1635c92b6 (diff) | |
| download | linux-d7ea0d9df2a6265b2b180d17ebc64b38105968fc.tar.gz linux-d7ea0d9df2a6265b2b180d17ebc64b38105968fc.tar.bz2 linux-d7ea0d9df2a6265b2b180d17ebc64b38105968fc.zip | |
net: remove two BUG() from skb_checksum_help()
I have a syzbot report that managed to get a crash in skb_checksum_help()
If syzbot can trigger these BUG(), it makes sense to replace
them with more friendly WARN_ON_ONCE() since skb_checksum_help()
can instead return an error code.
Note that syzbot will still crash there, until real bug is fixed.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/dev.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 186c6b07c60c..918548c73872 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3265,11 +3265,15 @@ int skb_checksum_help(struct sk_buff *skb) } offset = skb_checksum_start_offset(skb); - BUG_ON(offset >= skb_headlen(skb)); + ret = -EINVAL; + if (WARN_ON_ONCE(offset >= skb_headlen(skb))) + goto out; + csum = skb_checksum(skb, offset, skb->len - offset, 0); offset += skb->csum_offset; - BUG_ON(offset + sizeof(__sum16) > skb_headlen(skb)); + if (WARN_ON_ONCE(offset + sizeof(__sum16) > skb_headlen(skb))) + goto out; ret = skb_ensure_writable(skb, offset + sizeof(__sum16)); if (ret) |