diff options
| author | Joachim Fenkes <FENKES@de.ibm.com> | 2020-07-24 16:45:18 +0930 |
|---|---|---|
| committer | Joel Stanley <joel@jms.id.au> | 2021-06-04 16:06:57 +0930 |
| commit | 9ab1428dfe2c66b51e0b41337cd0164da0ab6080 (patch) | |
| tree | 13adf9f52366febba185ae56dbdc40ab210d09a8 | |
| parent | 95152433e46fdb36652ebdbea442356a16ae1fa6 (diff) | |
| download | linux-9ab1428dfe2c66b51e0b41337cd0164da0ab6080.tar.gz linux-9ab1428dfe2c66b51e0b41337cd0164da0ab6080.tar.bz2 linux-9ab1428dfe2c66b51e0b41337cd0164da0ab6080.zip | |
fsi/sbefifo: Fix reset timeout
On BMCs with lower timer resolution than 1ms, msleep(1) will take
way longer than 1ms, so looping 10k times won't wait for 10s but
significantly longer.
Fix this by using jiffies like the rest of the code.
Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
Link: https://lore.kernel.org/r/20200724071518.430515-3-joel@jms.id.au
Signed-off-by: Joel Stanley <joel@jms.id.au>
| -rw-r--r-- | drivers/fsi/fsi-sbefifo.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index de27c435d706..84cb965bfed5 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -325,7 +325,8 @@ static int sbefifo_up_write(struct sbefifo *sbefifo, __be32 word) static int sbefifo_request_reset(struct sbefifo *sbefifo) { struct device *dev = &sbefifo->fsi_dev->dev; - u32 status, timeout; + unsigned long end_time; + u32 status; int rc; dev_dbg(dev, "Requesting FIFO reset\n"); @@ -341,7 +342,8 @@ static int sbefifo_request_reset(struct sbefifo *sbefifo) } /* Wait for it to complete */ - for (timeout = 0; timeout < SBEFIFO_RESET_TIMEOUT; timeout++) { + end_time = jiffies + msecs_to_jiffies(SBEFIFO_RESET_TIMEOUT); + while (!time_after(jiffies, end_time)) { rc = sbefifo_regr(sbefifo, SBEFIFO_UP | SBEFIFO_STS, &status); if (rc) { dev_err(dev, "Failed to read UP fifo status during reset" @@ -355,7 +357,7 @@ static int sbefifo_request_reset(struct sbefifo *sbefifo) return 0; } - msleep(1); + cond_resched(); } dev_err(dev, "FIFO reset timed out\n"); |