diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-02-14 17:11:14 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-14 22:19:39 -0500 |
| commit | e70ac171658679ecf6bea4bbd9e9325cd6079d2b (patch) | |
| tree | 6757ae4ff0186cf6b68b57797c983b143577967b | |
| parent | a725eb15db80643a160310ed6bcfd6c5a6c907f2 (diff) | |
| download | linux-e70ac171658679ecf6bea4bbd9e9325cd6079d2b.tar.gz linux-e70ac171658679ecf6bea4bbd9e9325cd6079d2b.tar.bz2 linux-e70ac171658679ecf6bea4bbd9e9325cd6079d2b.zip | |
tcp: tcp_probe: use spin_lock_bh()
tcp_rcv_established() can now run in process context.
We need to disable BH while acquiring tcp probe spinlock,
or risk a deadlock.
Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Ricardo Nabinger Sanchez <rnsanchez@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/tcp_probe.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c index f6c50af24a64..3d063eb37848 100644 --- a/net/ipv4/tcp_probe.c +++ b/net/ipv4/tcp_probe.c @@ -117,7 +117,7 @@ static void jtcp_rcv_established(struct sock *sk, struct sk_buff *skb, (fwmark > 0 && skb->mark == fwmark)) && (full || tp->snd_cwnd != tcp_probe.lastcwnd)) { - spin_lock(&tcp_probe.lock); + spin_lock_bh(&tcp_probe.lock); /* If log fills, just silently drop */ if (tcp_probe_avail() > 1) { struct tcp_log *p = tcp_probe.log + tcp_probe.head; @@ -157,7 +157,7 @@ static void jtcp_rcv_established(struct sock *sk, struct sk_buff *skb, tcp_probe.head = (tcp_probe.head + 1) & (bufsize - 1); } tcp_probe.lastcwnd = tp->snd_cwnd; - spin_unlock(&tcp_probe.lock); + spin_unlock_bh(&tcp_probe.lock); wake_up(&tcp_probe.wait); } |