diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2017-03-05 19:14:07 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2017-03-08 14:01:10 +0800 |
| commit | 07de4bc88ce6a4d898cad9aa4c99c1df7e87702d (patch) | |
| tree | 292819498f4ddec783e6d0e40264280ce3e8adc0 | |
| parent | aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 (diff) | |
| download | linux-07de4bc88ce6a4d898cad9aa4c99c1df7e87702d.tar.gz linux-07de4bc88ce6a4d898cad9aa4c99c1df7e87702d.tar.bz2 linux-07de4bc88ce6a4d898cad9aa4c99c1df7e87702d.zip | |
crypto: s5p-sss - Fix completing crypto request in IRQ handler
In a regular interrupt handler driver was finishing the crypt/decrypt
request by calling complete on crypto request. This is disallowed since
converting to skcipher in commit b286d8b1a690 ("crypto: skcipher - Add
skcipher walk interface") and causes a warning:
WARNING: CPU: 0 PID: 0 at crypto/skcipher.c:430 skcipher_walk_first+0x13c/0x14c
The interrupt is marked shared but in fact there are no other users
sharing it. Thus the simplest solution seems to be to just use a
threaded interrupt handler, after converting it to oneshot.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | drivers/crypto/s5p-sss.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index dce1af0ce85c..a668286d62cb 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -805,8 +805,9 @@ static int s5p_aes_probe(struct platform_device *pdev) dev_warn(dev, "feed control interrupt is not available.\n"); goto err_irq; } - err = devm_request_irq(dev, pdata->irq_fc, s5p_aes_interrupt, - IRQF_SHARED, pdev->name, pdev); + err = devm_request_threaded_irq(dev, pdata->irq_fc, NULL, + s5p_aes_interrupt, IRQF_ONESHOT, + pdev->name, pdev); if (err < 0) { dev_warn(dev, "feed control interrupt is not available.\n"); goto err_irq; |