diff options
| author | Filipe Manana <fdmanana@suse.com> | 2019-06-19 13:05:50 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-07-02 12:30:50 +0200 |
| commit | 179006688a7e888cbff39577189f2e034786d06a (patch) | |
| tree | df6214bbdcb1bb1e30eb356ea251c1ce52948d17 | |
| parent | 803f0f64d17769071d7287d9e3e3b79a3e1ae937 (diff) | |
| download | linux-179006688a7e888cbff39577189f2e034786d06a.tar.gz linux-179006688a7e888cbff39577189f2e034786d06a.tar.bz2 linux-179006688a7e888cbff39577189f2e034786d06a.zip | |
Btrfs: add missing inode version, ctime and mtime updates when punching hole
If the range for which we are punching a hole covers only part of a page,
we end up updating the inode item but we skip the update of the inode's
iversion, mtime and ctime. Fix that by ensuring we update those properties
of the inode.
A patch for fstests test case generic/059 that tests this as been sent
along with this fix.
Fixes: 2aaa66558172b0 ("Btrfs: add hole punching")
Fixes: e8c1c76e804b18 ("Btrfs: add missing inode update when punching hole")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/file.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 5370152ea7e3..b455bdf46faa 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -2711,6 +2711,11 @@ out_only_mutex: * for detecting, at fsync time, if the inode isn't yet in the * log tree or it's there but not up to date. */ + struct timespec64 now = current_time(inode); + + inode_inc_iversion(inode); + inode->i_mtime = now; + inode->i_ctime = now; trans = btrfs_start_transaction(root, 1); if (IS_ERR(trans)) { err = PTR_ERR(trans); |