diff options
| author | Roland Dreier <rolandd@cisco.com> | 2007-05-19 08:51:54 -0700 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2007-05-19 08:51:54 -0700 |
| commit | 1af4c435f3ab9cdf72ce86c35a455c8bef1d6536 (patch) | |
| tree | 1eb15a6c95638bb0446b4d92d5472bcd1adec75e | |
| parent | 5eb620c81ce35aa0c533131bf4d06c4c8c2bfadf (diff) | |
| download | linux-1af4c435f3ab9cdf72ce86c35a455c8bef1d6536.tar.gz linux-1af4c435f3ab9cdf72ce86c35a455c8bef1d6536.tar.bz2 linux-1af4c435f3ab9cdf72ce86c35a455c8bef1d6536.zip | |
IB/core: Use start_port() and end_port()
Clean up ib_query_port() and ib_modify_port() slightly by using the
just-added start_port() and end_port() helpers.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
| -rw-r--r-- | drivers/infiniband/core/device.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index b448e0b2b6b4..b58319642014 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -569,10 +569,7 @@ int ib_query_port(struct ib_device *device, u8 port_num, struct ib_port_attr *port_attr) { - if (device->node_type == RDMA_NODE_IB_SWITCH) { - if (port_num) - return -EINVAL; - } else if (port_num < 1 || port_num > device->phys_port_cnt) + if (port_num < start_port(device) || port_num > end_port(device)) return -EINVAL; return device->query_port(device, port_num, port_attr); @@ -644,10 +641,7 @@ int ib_modify_port(struct ib_device *device, u8 port_num, int port_modify_mask, struct ib_port_modify *port_modify) { - if (device->node_type == RDMA_NODE_IB_SWITCH) { - if (port_num) - return -EINVAL; - } else if (port_num < 1 || port_num > device->phys_port_cnt) + if (port_num < start_port(device) || port_num > end_port(device)) return -EINVAL; return device->modify_port(device, port_num, port_modify_mask, |