diff options
| author | Dawei Li <set_pte_at@outlook.com> | 2024-04-10 21:13:59 +0800 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2024-05-04 12:50:42 +0200 |
| commit | 4c97f0433de08ab4b52d7a2747daf44430c6d489 (patch) | |
| tree | 764a3ac32d8c150d9b979bed13ee1b687d52128f | |
| parent | e3b3afd34d84efcbe4543deb966b1990f43584b8 (diff) | |
| download | linux-4c97f0433de08ab4b52d7a2747daf44430c6d489.tar.gz linux-4c97f0433de08ab4b52d7a2747daf44430c6d489.tar.bz2 linux-4c97f0433de08ab4b52d7a2747daf44430c6d489.zip | |
watchdog/wdt-main: Use cpumask_of() to avoid cpumask var on stack
In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.
Use cpumask_of() to avoid the need for a temporary cpumask on the stack
Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/TYTP286MB3564B037A81DAAE1AC3A16F3CA062@TYTP286MB3564.JPNP286.PROD.OUTLOOK.COM
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
| -rw-r--r-- | drivers/watchdog/octeon-wdt-main.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/watchdog/octeon-wdt-main.c b/drivers/watchdog/octeon-wdt-main.c index 0fe71f7e66d5..52d49e4e35a0 100644 --- a/drivers/watchdog/octeon-wdt-main.c +++ b/drivers/watchdog/octeon-wdt-main.c @@ -381,11 +381,7 @@ static int octeon_wdt_cpu_online(unsigned int cpu) /* Must set the irq affinity here */ if (octeon_has_feature(OCTEON_FEATURE_CIU3)) { - cpumask_t mask; - - cpumask_clear(&mask); - cpumask_set_cpu(cpu, &mask); - irq_set_affinity(irq, &mask); + irq_set_affinity(irq, cpumask_of(cpu)); } cpumask_set_cpu(cpu, &irq_enabled_cpus); |