diff options
| author | Varka Bhadram <varkabhadram@gmail.com> | 2015-06-23 11:41:03 +0530 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2015-07-23 17:10:48 +0200 |
| commit | 8f451829dd97fb22f03844ca52a49828e2e1d666 (patch) | |
| tree | 05b1b95656fd6a925d8e80b62c3dc0c49d1555cd | |
| parent | 301d7d42a207e0d4f5bf11c7e2b6862ddebc8c36 (diff) | |
| download | linux-8f451829dd97fb22f03844ca52a49828e2e1d666.tar.gz linux-8f451829dd97fb22f03844ca52a49828e2e1d666.tar.bz2 linux-8f451829dd97fb22f03844ca52a49828e2e1d666.zip | |
mac802154: use WARN_ON() macro
This patch will generate the warning if the required driver ops
were not defined. Also it removes unnecessary debug message.
Signed-off-by: Varka Bhadram <varkab@cdac.in>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
| -rw-r--r-- | net/mac802154/main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/mac802154/main.c b/net/mac802154/main.c index 356b346e1ee8..4caf04b676d7 100644 --- a/net/mac802154/main.c +++ b/net/mac802154/main.c @@ -58,11 +58,9 @@ ieee802154_alloc_hw(size_t priv_data_len, const struct ieee802154_ops *ops) struct ieee802154_local *local; size_t priv_size; - if (!ops || !(ops->xmit_async || ops->xmit_sync) || !ops->ed || - !ops->start || !ops->stop || !ops->set_channel) { - pr_err("undefined IEEE802.15.4 device operations\n"); + if (WARN_ON(!ops || !(ops->xmit_async || ops->xmit_sync) || !ops->ed || + !ops->start || !ops->stop || !ops->set_channel)) return NULL; - } /* Ensure 32-byte alignment of our private data and hw private data. * We use the wpan_phy priv data for both our ieee802154_local and for |