diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-09 10:38:56 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2023-10-10 15:45:35 +0200 |
| commit | 93650550dff9d1a3b88c553f8adb81dc89778977 (patch) | |
| tree | 7931ce9c39cf70fcff4ecf8d3b53d22f9ee8fcff | |
| parent | a80252efb5d539b292433189f282f80aabaa53b1 (diff) | |
| download | linux-93650550dff9d1a3b88c553f8adb81dc89778977.tar.gz linux-93650550dff9d1a3b88c553f8adb81dc89778977.tar.bz2 linux-93650550dff9d1a3b88c553f8adb81dc89778977.zip | |
pinctrl: ti: ti-iodelay: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231009083856.222030-21-u.kleine-koenig@pengutronix.de
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c index f3a273562095..0ac2548ca68d 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -896,10 +896,8 @@ exit_out: /** * ti_iodelay_remove() - standard remove * @pdev: platform device - * - * Return: 0 if all went fine, else appropriate error value. */ -static int ti_iodelay_remove(struct platform_device *pdev) +static void ti_iodelay_remove(struct platform_device *pdev) { struct ti_iodelay_device *iod = platform_get_drvdata(pdev); @@ -909,13 +907,11 @@ static int ti_iodelay_remove(struct platform_device *pdev) ti_iodelay_pinconf_deinit_dev(iod); /* Expect other allocations to be freed by devm */ - - return 0; } static struct platform_driver ti_iodelay_driver = { .probe = ti_iodelay_probe, - .remove = ti_iodelay_remove, + .remove_new = ti_iodelay_remove, .driver = { .name = DRIVER_NAME, .of_match_table = ti_iodelay_of_match, |