summaryrefslogtreecommitdiffstats
path: root/Documentation/phy
diff options
context:
space:
mode:
authorMike Kravetz <mike.kravetz@oracle.com>2017-11-29 16:10:01 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-11-29 18:40:42 -0800
commit63cd448908b5eb51d84c52f02b31b9b4ccd1cb5a (patch)
tree324076c60e4a8b4f7064326e810f342bc8527236 /Documentation/phy
parent687cb0884a714ff484d038e9190edc874edcf146 (diff)
downloadlinux-63cd448908b5eb51d84c52f02b31b9b4ccd1cb5a.tar.gz
linux-63cd448908b5eb51d84c52f02b31b9b4ccd1cb5a.tar.bz2
linux-63cd448908b5eb51d84c52f02b31b9b4ccd1cb5a.zip
mm/cma: fix alloc_contig_range ret code/potential leak
If the call __alloc_contig_migrate_range() in alloc_contig_range returns -EBUSY, processing continues so that test_pages_isolated() is called where there is a tracepoint to identify the busy pages. However, it is possible for busy pages to become available between the calls to these two routines. In this case, the range of pages may be allocated. Unfortunately, the original return code (ret == -EBUSY) is still set and returned to the caller. Therefore, the caller believes the pages were not allocated and they are leaked. Update the comment to indicate that allocation is still possible even if __alloc_contig_migrate_range returns -EBUSY. Also, clear return code in this case so that it is not accidentally used or returned to caller. Link: http://lkml.kernel.org/r/20171122185214.25285-1-mike.kravetz@oracle.com Fixes: 8ef5849fa8a2 ("mm/cma: always check which page caused allocation failure") Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Michal Nazarewicz <mina86@mina86.com> Cc: Laura Abbott <labbott@redhat.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/phy')
0 files changed, 0 insertions, 0 deletions