summaryrefslogtreecommitdiffstats
path: root/Documentation/serial
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2014-10-16 16:54:19 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-05 18:53:54 -0800
commit2e758910832dce99761a29688b33fd77dcbf6f6c (patch)
tree792bf3c623230c21a325dfe8bf91dda9d26af96a /Documentation/serial
parent479e9b94fdce7bc46f669831012fc12f56696fd7 (diff)
downloadlinux-2e758910832dce99761a29688b33fd77dcbf6f6c.tar.gz
linux-2e758910832dce99761a29688b33fd77dcbf6f6c.tar.bz2
linux-2e758910832dce99761a29688b33fd77dcbf6f6c.zip
serial: core: Flush ldisc after dropping port mutex in uart_close()
The tty buffers (and any line discipline buffers) must be flushed after the UART hardware has shutdown; otherwise, a racing open on the same tty may receive data from the previous session, which is a security hazard. However, holding the port mutex while flushing the line discipline buffers creates a lock inversion if the set_termios() handler takes the port mutex (as it does in the followup patch, 'serial: Fix locking for uart driver set_termios method'. Flush the ldisc buffers after dropping the port mutex; the tty lock is still held which prevents a concurrent open() from advancing while flushing. Since no new rx data is possible after uart_shutdown() until a new open reinitializes the port, the later flush has no impact on what data is being discarded. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/serial')
0 files changed, 0 insertions, 0 deletions