diff options
author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2017-05-12 14:38:03 +0200 |
---|---|---|
committer | Eric Anholt <eric@anholt.net> | 2017-06-12 17:11:39 -0700 |
commit | d0b1d259a4b58b21a21ea82d7174bf7ea825e9cc (patch) | |
tree | 478890f4ecd797fd31e89b1e8b7b66e00f3f5801 /Documentation | |
parent | 24bb206f32cdaa76c59444b62be51708dc16fbe8 (diff) | |
download | linux-d0b1d259a4b58b21a21ea82d7174bf7ea825e9cc.tar.gz linux-d0b1d259a4b58b21a21ea82d7174bf7ea825e9cc.tar.bz2 linux-d0b1d259a4b58b21a21ea82d7174bf7ea825e9cc.zip |
drm/vc4: Fix resource leak in 'vc4_get_hang_state_ioctl()' in error handling path
If one 'drm_gem_handle_create()' fails, we leak somes handles and some
memory.
In order to fix it:
- move the 'free(bo_state)' at the end of the function so that it is also
called in the eror handling path. This has the side effect to also try
to free it if the first 'kcalloc' fails. This is harmless.
- add a new label, err_delete_handle, in order to delete already
allocated handles in error handling path
- remove the now useless 'err' label
The way the code is now written will also delete the handles if the
'copy_to_user()' call fails.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170512123803.1886-1-christophe.jaillet@wanadoo.fr
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions