diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2017-12-13 11:45:42 +0000 |
|---|---|---|
| committer | Will Deacon <will.deacon@arm.com> | 2017-12-14 10:18:23 +0000 |
| commit | 1d08a044cf12aee37dfd54837558e3295287b343 (patch) | |
| tree | 3358dfba081ea3db3c807a7565bfb26ce836c95e /arch/arm64 | |
| parent | faa75e147b583417273902552c61cf3250a44308 (diff) | |
| download | linux-1d08a044cf12aee37dfd54837558e3295287b343.tar.gz linux-1d08a044cf12aee37dfd54837558e3295287b343.tar.bz2 linux-1d08a044cf12aee37dfd54837558e3295287b343.zip | |
arm64: fix CONFIG_DEBUG_WX address reporting
In ptdump_check_wx(), we pass walk_pgd() a start address of 0 (rather
than VA_START) for the init_mm. This means that any reported W&X
addresses are offset by VA_START, which is clearly wrong and can make
them appear like userspace addresses.
Fix this by telling the ptdump code that we're walking init_mm starting
at VA_START. We don't need to update the addr_markers, since these are
still valid bounds regardless.
Cc: <stable@vger.kernel.org>
Fixes: 1404d6f13e47 ("arm64: dump: Add checking for writable and exectuable pages")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Laura Abbott <labbott@redhat.com>
Reported-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'arch/arm64')
| -rw-r--r-- | arch/arm64/mm/dump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c index ca74a2aace42..7b60d62ac593 100644 --- a/arch/arm64/mm/dump.c +++ b/arch/arm64/mm/dump.c @@ -389,7 +389,7 @@ void ptdump_check_wx(void) .check_wx = true, }; - walk_pgd(&st, &init_mm, 0); + walk_pgd(&st, &init_mm, VA_START); note_page(&st, 0, 0, 0); if (st.wx_pages || st.uxn_pages) pr_warn("Checked W+X mappings: FAILED, %lu W+X pages found, %lu non-UXN pages found\n", |