diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 15:40:27 +0100 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2016-01-24 02:21:47 +0100 |
| commit | 249e573d99ab590e19bd23f084f8c6540daa7b06 (patch) | |
| tree | 45ba3b4418a1f89a1d6344740cbb19ab46daa2f7 /arch/mips/ar7 | |
| parent | 7b42c00a95c02d962b18f8ed8bf59b65ae58d3ee (diff) | |
| download | linux-249e573d99ab590e19bd23f084f8c6540daa7b06.tar.gz linux-249e573d99ab590e19bd23f084f8c6540daa7b06.tar.bz2 linux-249e573d99ab590e19bd23f084f8c6540daa7b06.zip | |
MIPS: ar7: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11922/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/ar7')
| -rw-r--r-- | arch/mips/ar7/gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c index f4930456eb8e..f969f583c68c 100644 --- a/arch/mips/ar7/gpio.c +++ b/arch/mips/ar7/gpio.c @@ -37,7 +37,7 @@ static int ar7_gpio_get_value(struct gpio_chip *chip, unsigned gpio) container_of(chip, struct ar7_gpio_chip, chip); void __iomem *gpio_in = gpch->regs + AR7_GPIO_INPUT; - return readl(gpio_in) & (1 << gpio); + return !!(readl(gpio_in) & (1 << gpio)); } static int titan_gpio_get_value(struct gpio_chip *chip, unsigned gpio) |