diff options
| author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2019-01-02 20:43:01 +0200 |
|---|---|---|
| committer | Paul Burton <paul.burton@mips.com> | 2019-01-02 14:17:24 -0800 |
| commit | edefae94b7b9f10d5efe32dece5a36e9d9ecc29e (patch) | |
| tree | f9baa2ba94383ff04f30656736efadeb0a3fee73 /arch/mips | |
| parent | db1ce3f5d01d2d6d5714aefba0159d2cb5167a0b (diff) | |
| download | linux-edefae94b7b9f10d5efe32dece5a36e9d9ecc29e.tar.gz linux-edefae94b7b9f10d5efe32dece5a36e9d9ecc29e.tar.bz2 linux-edefae94b7b9f10d5efe32dece5a36e9d9ecc29e.zip | |
MIPS: OCTEON: mark RGMII interface disabled on OCTEON III
Commit 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx
interface detection") added RGMII interface detection for OCTEON III,
but it results in the following logs:
[ 7.165984] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
[ 7.173017] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
The current RGMII routines are valid only for older OCTEONS that
use GMX/ASX hardware blocks. On later chips AGL should be used,
but support for that is missing in the mainline. Until that is added,
mark the interface as disabled.
Fixes: 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: stable@vger.kernel.org # 4.7+
Diffstat (limited to 'arch/mips')
| -rw-r--r-- | arch/mips/cavium-octeon/executive/cvmx-helper.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c index d2251bb1f369..539dd30d6188 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c @@ -266,7 +266,8 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7xxx(int interface) case 3: return CVMX_HELPER_INTERFACE_MODE_LOOP; case 4: - return CVMX_HELPER_INTERFACE_MODE_RGMII; + /* TODO: Implement support for AGL (RGMII). */ + return CVMX_HELPER_INTERFACE_MODE_DISABLED; default: return CVMX_HELPER_INTERFACE_MODE_DISABLED; } |