diff options
| author | Marcelo Tosatti <mtosatti@redhat.com> | 2008-04-16 17:19:06 -0300 |
|---|---|---|
| committer | Avi Kivity <avi@qumranet.com> | 2008-04-27 18:21:45 +0300 |
| commit | 960b3991698872f68f09d51f4c2794ad484fe1fd (patch) | |
| tree | a5b2d84dfb0f7009538c1c07ca5e244da2be3956 /arch/x86/kvm/mmu.c | |
| parent | 1336028b9a1fb33537eab8caec66e812eb8cad63 (diff) | |
| download | linux-960b3991698872f68f09d51f4c2794ad484fe1fd.tar.gz linux-960b3991698872f68f09d51f4c2794ad484fe1fd.tar.bz2 linux-960b3991698872f68f09d51f4c2794ad484fe1fd.zip | |
KVM: MMU: kvm_pv_mmu_op should not take mmap_sem
kvm_pv_mmu_op should not take mmap_sem. All gfn_to_page() callers down
in the MMU processing will take it if necessary, so as it is it can
deadlock.
Apparently a leftover from the days before slots_lock.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Diffstat (limited to 'arch/x86/kvm/mmu.c')
| -rw-r--r-- | arch/x86/kvm/mmu.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 078a7f1ac34c..2ad6f5481671 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -2173,8 +2173,6 @@ int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, int r; struct kvm_pv_mmu_op_buffer buffer; - down_read(¤t->mm->mmap_sem); - buffer.ptr = buffer.buf; buffer.len = min_t(unsigned long, bytes, sizeof buffer.buf); buffer.processed = 0; @@ -2194,7 +2192,6 @@ int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, r = 1; out: *ret = buffer.processed; - up_read(¤t->mm->mmap_sem); return r; } |