diff options
author | Robert Richter <robert.richter@amd.com> | 2011-05-30 16:31:11 +0200 |
---|---|---|
committer | Robert Richter <robert.richter@amd.com> | 2011-05-30 16:36:54 +0200 |
commit | cbf74cea070fa1f705de4712e25d9e56ae6543c7 (patch) | |
tree | dce39e94a735df4953415720d85d7ed106f71075 /arch/x86/oprofile | |
parent | b76a06e08d94b2a63e47837dfe46bbbf0a3af6c2 (diff) | |
download | linux-cbf74cea070fa1f705de4712e25d9e56ae6543c7.tar.gz linux-cbf74cea070fa1f705de4712e25d9e56ae6543c7.tar.bz2 linux-cbf74cea070fa1f705de4712e25d9e56ae6543c7.zip |
oprofile, x86: Add comments to IBS LVT offset initialization
Adding a comment in the code as IBS LVT setup is not obvious at all ...
Signed-off-by: Robert Richter <robert.richter@amd.com>
Diffstat (limited to 'arch/x86/oprofile')
-rw-r--r-- | arch/x86/oprofile/op_model_amd.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c index 9fd8a567fe1e..9cbb710dc94b 100644 --- a/arch/x86/oprofile/op_model_amd.c +++ b/arch/x86/oprofile/op_model_amd.c @@ -609,16 +609,21 @@ static int setup_ibs_ctl(int ibs_eilvt_off) return 0; } +/* + * This runs only on the current cpu. We try to find an LVT offset and + * setup the local APIC. For this we must disable preemption. On + * success we initialize all nodes with this offset. This updates then + * the offset in the IBS_CTL per-node msr. The per-core APIC setup of + * the IBS interrupt vector is called from op_amd_setup_ctrs()/op_- + * amd_cpu_shutdown() using the new offset. + */ static int force_ibs_eilvt_setup(void) { int offset; int ret; - /* - * find the next free available EILVT entry, skip offset 0, - * pin search to this cpu - */ preempt_disable(); + /* find the next free available EILVT entry, skip offset 0 */ for (offset = 1; offset < APIC_EILVT_NR_MAX; offset++) { if (get_eilvt(offset)) break; |