summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorAndi Kleen <ak@suse.de>2007-02-13 13:26:24 +0100
committerAndi Kleen <andi@basil.nowhere.org>2007-02-13 13:26:24 +0100
commitf49481bc50fce428521497977861b8115666dbe7 (patch)
tree82b104f236cbc9b57d906c79c432fd8bb2d46bd8 /arch
parent2f7a2a79c3ebb44f8b1b7d9b4fd3a650eb69e544 (diff)
downloadlinux-f49481bc50fce428521497977861b8115666dbe7.tar.gz
linux-f49481bc50fce428521497977861b8115666dbe7.tar.bz2
linux-f49481bc50fce428521497977861b8115666dbe7.zip
[PATCH] x86-64: Check return value of putreg in PTRACE_SETREGS
This means if an illegal value is set for the segment registers there ptrace will error out now with an errno instead of silently ignoring it. Signed-off-by: Andi Kleen <ak@suse.de>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86_64/kernel/ptrace.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/arch/x86_64/kernel/ptrace.c b/arch/x86_64/kernel/ptrace.c
index addc14af0c56..4326a690a509 100644
--- a/arch/x86_64/kernel/ptrace.c
+++ b/arch/x86_64/kernel/ptrace.c
@@ -536,8 +536,12 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
}
ret = 0;
for (ui = 0; ui < sizeof(struct user_regs_struct); ui += sizeof(long)) {
- ret |= __get_user(tmp, (unsigned long __user *) data);
- putreg(child, ui, tmp);
+ ret = __get_user(tmp, (unsigned long __user *) data);
+ if (ret)
+ break;
+ ret = putreg(child, ui, tmp);
+ if (ret)
+ break;
data += sizeof(long);
}
break;