summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2009-03-24 14:17:19 -0700
committerIngo Molnar <mingo@elte.hu>2009-03-25 18:48:29 +0100
commite06b1b56f9bfcc91e1f175fe8d8bf3e35dafa080 (patch)
tree7bb1a3a9e38bb8af4ead2177573c17356e16563d /arch
parentf56e5034121c4911a155ba907076ab920754626d (diff)
downloadlinux-e06b1b56f9bfcc91e1f175fe8d8bf3e35dafa080.tar.gz
linux-e06b1b56f9bfcc91e1f175fe8d8bf3e35dafa080.tar.bz2
linux-e06b1b56f9bfcc91e1f175fe8d8bf3e35dafa080.zip
x86: Correct behaviour of irq affinity
Impact: get correct smp_affinity as user requested The effect of setting desc->affinity (ie. from userspace via sysfs) has varied over time. In 2.6.27, the 32-bit code anded the value with cpu_online_map, and both 32 and 64-bit did that anding whenever a cpu was unplugged. 2.6.29 consolidated this into one routine (and fixed hotplug) but introduced another variation: anding the affinity with cfg->domain. We should just set it to what the user said - if possible. (cpu_mask_to_apicid_and already takes cpu_online_mask into account) Signed-off-by: Yinghai Lu <yinghai@kernel.org> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Andrew Morton <akpm@linux-foundation.org> LKML-Reference: <49C94DDF.2010703@kernel.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86/kernel/apic/io_apic.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 1ed6c0600cde..d990408ca06f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -594,9 +594,10 @@ set_desc_affinity(struct irq_desc *desc, const struct cpumask *mask)
/* check that before desc->addinity get updated */
set_extra_move_desc(desc, mask);
- cpumask_and(desc->affinity, cfg->domain, mask);
- return apic->cpu_mask_to_apicid_and(desc->affinity, cpu_online_mask);
+ cpumask_copy(desc->affinity, mask);
+
+ return apic->cpu_mask_to_apicid_and(desc->affinity, cfg->domain);
}
static void