diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2022-09-21 17:53:09 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-09-24 08:59:43 -0600 |
| commit | 81c7a63abc7c0be572b4f853e913ce93a34f6e1b (patch) | |
| tree | 3358a474ca304876e431085299e980128c58116e /block/blk-throttle.c | |
| parent | 85496749904016f36b69332f73a1cf3ecfee828f (diff) | |
| download | linux-81c7a63abc7c0be572b4f853e913ce93a34f6e1b.tar.gz linux-81c7a63abc7c0be572b4f853e913ce93a34f6e1b.tar.bz2 linux-81c7a63abc7c0be572b4f853e913ce93a34f6e1b.zip | |
blk-throttle: improve bypassing bios checkings
"tg->has_rules" is extended to "tg->has_rules_iops/bps", thus bios that
don't need to be throttled can be checked accurately.
With this patch, bio will be throttled if:
1) Bio is read/write, and corresponding read/write iops limit exist.
2) If corresponding doesn't exist, corresponding bps limit exist and
bio is not throttled before.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20220921095309.1481289-3-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-throttle.c')
| -rw-r--r-- | block/blk-throttle.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index a062539d84d0..78316955e30f 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -421,11 +421,16 @@ static void tg_update_has_rules(struct throtl_grp *tg) struct throtl_data *td = tg->td; int rw; - for (rw = READ; rw <= WRITE; rw++) - tg->has_rules[rw] = (parent_tg && parent_tg->has_rules[rw]) || + for (rw = READ; rw <= WRITE; rw++) { + tg->has_rules_iops[rw] = + (parent_tg && parent_tg->has_rules_iops[rw]) || (td->limit_valid[td->limit_index] && - (tg_bps_limit(tg, rw) != U64_MAX || - tg_iops_limit(tg, rw) != UINT_MAX)); + tg_iops_limit(tg, rw) != UINT_MAX); + tg->has_rules_bps[rw] = + (parent_tg && parent_tg->has_rules_bps[rw]) || + (td->limit_valid[td->limit_index] && + (tg_bps_limit(tg, rw) != U64_MAX)); + } } static void throtl_pd_online(struct blkg_policy_data *pd) |