diff options
author | David Kozub <zub@linux.fjfi.cvut.cz> | 2019-02-14 01:15:53 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-04-06 11:09:12 -0600 |
commit | 78bf47353b0041865564deeed257a54f047c2fdc (patch) | |
tree | 30023669c2a054a2f8915e621c38187ba154fd28 /block/ioctl.c | |
parent | 72deb455b5ec619ff043c30bc90025aa3de3cdda (diff) | |
download | linux-78bf47353b0041865564deeed257a54f047c2fdc.tar.gz linux-78bf47353b0041865564deeed257a54f047c2fdc.tar.bz2 linux-78bf47353b0041865564deeed257a54f047c2fdc.zip |
block: sed-opal: fix IOC_OPAL_ENABLE_DISABLE_MBR
The implementation of IOC_OPAL_ENABLE_DISABLE_MBR handled the value
opal_mbr_data.enable_disable incorrectly: enable_disable is expected
to be one of OPAL_MBR_ENABLE(0) or OPAL_MBR_DISABLE(1). enable_disable
was passed directly to set_mbr_done and set_mbr_enable_disable where
is was interpreted as either OPAL_TRUE(1) or OPAL_FALSE(0). The end
result was that calling IOC_OPAL_ENABLE_DISABLE_MBR with OPAL_MBR_ENABLE
actually disabled the shadow MBR and vice versa.
This patch adds correct conversion from OPAL_MBR_DISABLE/ENABLE to
OPAL_FALSE/TRUE. The change affects existing programs using
IOC_OPAL_ENABLE_DISABLE_MBR but this is typically used only once when
setting up an Opal drive.
Acked-by: Jon Derrick <jonathan.derrick@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/ioctl.c')
0 files changed, 0 insertions, 0 deletions