diff options
| author | Tejun Heo <tj@kernel.org> | 2021-04-22 21:54:28 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-04-26 06:44:18 -0600 |
| commit | f46ec84b5acbf8d7067d71a6bbdde213d4b86036 (patch) | |
| tree | 752b0dc8602de6580ee5ab5699662c6814ea87d1 /block | |
| parent | 1e91e28e374d0b0b912154c192716374609360d9 (diff) | |
| download | linux-f46ec84b5acbf8d7067d71a6bbdde213d4b86036.tar.gz linux-f46ec84b5acbf8d7067d71a6bbdde213d4b86036.tar.bz2 linux-f46ec84b5acbf8d7067d71a6bbdde213d4b86036.zip | |
blk-iocost: don't ignore vrate_min on QD contention
ioc_adjust_base_vrate() ignored vrate_min when rq_wait_pct indicates that
there is QD contention. The reasoning was that QD depletion always reliably
indicates device saturation and thus it's safe to override user specified
vrate_min. However, this sometimes leads to unnecessary throttling,
especially on really fast devices, because vrate adjustments have delays and
inertia. It also confuses users because the behavior violates the explicitly
specified configuration.
This patch drops the special case handling so that vrate_min is always
applied.
Signed-off-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/YIIo1HuyNmhDeiNx@slm.duckdns.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-iocost.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 98d656bdb42b..e0c4baa01857 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -987,10 +987,6 @@ static void ioc_adjust_base_vrate(struct ioc *ioc, u32 rq_wait_pct, return; } - /* rq_wait signal is always reliable, ignore user vrate_min */ - if (rq_wait_pct > RQ_WAIT_BUSY_PCT) - vrate_min = VRATE_MIN; - /* * If vrate is out of bounds, apply clamp gradually as the * bounds can change abruptly. Otherwise, apply busy_level |