diff options
| author | Bart Van Assche <bart.vanassche@wdc.com> | 2018-01-02 11:39:48 -0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-01-05 09:03:04 -0700 |
| commit | 882d4171a8950646413b1a3cbe0e4a6a612fe82e (patch) | |
| tree | 92dd5094dad515ec3003900354d96f50098df1df /block | |
| parent | 5a0ec388ef0f6e33841aeb810d7fa23f049ec4cd (diff) | |
| download | linux-882d4171a8950646413b1a3cbe0e4a6a612fe82e.tar.gz linux-882d4171a8950646413b1a3cbe0e4a6a612fe82e.tar.bz2 linux-882d4171a8950646413b1a3cbe0e4a6a612fe82e.zip | |
pktcdvd: Fix a recently introduced NULL pointer dereference
Call bdev_get_queue(bdev) after bdev->bd_disk has been initialized
instead of just before that pointer has been initialized. This patch
avoids that the following command
pktsetup 1 /dev/sr0
triggers the following kernel crash:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000548
IP: pkt_setup_dev+0x2db/0x670 [pktcdvd]
CPU: 2 PID: 724 Comm: pktsetup Not tainted 4.15.0-rc4-dbg+ #1
Call Trace:
pkt_ctl_ioctl+0xce/0x1c0 [pktcdvd]
do_vfs_ioctl+0x8e/0x670
SyS_ioctl+0x3c/0x70
entry_SYSCALL_64_fastpath+0x23/0x9a
Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: <stable@vger.kernel.org> # v4.13
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions