diff options
| author | Chengming Zhou <zhouchengming@bytedance.com> | 2020-07-30 17:03:21 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-07-30 11:45:12 -0600 |
| commit | d9012a59db54442d5b2fcfdfcded35cf566397d3 (patch) | |
| tree | e0ca1de20967be26d86cf71aa868e87195830029 /block | |
| parent | 0516c2f6ae6570a0c4a081189d71a48cfadc34a7 (diff) | |
| download | linux-d9012a59db54442d5b2fcfdfcded35cf566397d3.tar.gz linux-d9012a59db54442d5b2fcfdfcded35cf566397d3.tar.bz2 linux-d9012a59db54442d5b2fcfdfcded35cf566397d3.zip | |
iocost: Fix check condition of iocg abs_vdebt
We shouldn't skip iocg when its abs_vdebt is not zero.
Fixes: 0b80f9866e6b ("iocost: protect iocg->abs_vdebt with iocg->waitq.lock")
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-iocost.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index cea5ee9be639..521c29b8ae29 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -1370,7 +1370,7 @@ static void ioc_timer_fn(struct timer_list *timer) * should have woken up in the last period and expire idle iocgs. */ list_for_each_entry_safe(iocg, tiocg, &ioc->active_iocgs, active_list) { - if (!waitqueue_active(&iocg->waitq) && iocg->abs_vdebt && + if (!waitqueue_active(&iocg->waitq) && !iocg->abs_vdebt && !iocg_is_idle(iocg)) continue; |