summaryrefslogtreecommitdiffstats
path: root/crypto/crypto_user_base.c
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:29:16 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2019-10-10 23:42:45 +1100
commitffdde5932042600c6807d46c1550b28b0db6a3bc (patch)
treef9e56b0a2489dcbc774a218e9c6c8eae17dcff74 /crypto/crypto_user_base.c
parent64e7f852c47ce99f6c324c46d6a299a5a7ebead9 (diff)
downloadlinux-ffdde5932042600c6807d46c1550b28b0db6a3bc.tar.gz
linux-ffdde5932042600c6807d46c1550b28b0db6a3bc.tar.bz2
linux-ffdde5932042600c6807d46c1550b28b0db6a3bc.zip
crypto: user - fix memory leak in crypto_report
In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails. Fixes: a38f7907b926 ("crypto: Add userspace configuration API") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/crypto_user_base.c')
-rw-r--r--crypto/crypto_user_base.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_base.c b/crypto/crypto_user_base.c
index 910e0b46012e..b785c476de67 100644
--- a/crypto/crypto_user_base.c
+++ b/crypto/crypto_user_base.c
@@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}