summaryrefslogtreecommitdiffstats
path: root/crypto/md5.c
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2019-06-02 22:40:57 -0700
committerHerbert Xu <herbert@gondor.apana.org.au>2019-06-13 14:31:39 +0800
commitd6ebf5286f8f94a254a8c90d4b9f2a8b076a8634 (patch)
tree863854e36421d48df925cdd0292fdb9373554901 /crypto/md5.c
parent7545b6c2087f4ef0287c8c9b7eba6a728c67ff8e (diff)
downloadlinux-d6ebf5286f8f94a254a8c90d4b9f2a8b076a8634.tar.gz
linux-d6ebf5286f8f94a254a8c90d4b9f2a8b076a8634.tar.bz2
linux-d6ebf5286f8f94a254a8c90d4b9f2a8b076a8634.zip
crypto: make all generic algorithms set cra_driver_name
Most generic crypto algorithms declare a driver name ending in "-generic". The rest don't declare a driver name and instead rely on the crypto API automagically appending "-generic" upon registration. Having multiple conventions is unnecessarily confusing and makes it harder to grep for all generic algorithms in the kernel source tree. But also, allowing NULL driver names is problematic because sometimes people fail to set it, e.g. the case fixed by commit 417980364300 ("crypto: cavium/zip - fix collision with generic cra_driver_name"). Of course, people can also incorrectly name their drivers "-generic". But that's much easier to notice / grep for. Therefore, let's make cra_driver_name mandatory. In preparation for this, this patch makes all generic algorithms set cra_driver_name. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/md5.c')
-rw-r--r--crypto/md5.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/crypto/md5.c b/crypto/md5.c
index 221c2c0932f8..22dc60bc0437 100644
--- a/crypto/md5.c
+++ b/crypto/md5.c
@@ -228,9 +228,10 @@ static struct shash_alg alg = {
.descsize = sizeof(struct md5_state),
.statesize = sizeof(struct md5_state),
.base = {
- .cra_name = "md5",
- .cra_blocksize = MD5_HMAC_BLOCK_SIZE,
- .cra_module = THIS_MODULE,
+ .cra_name = "md5",
+ .cra_driver_name = "md5-generic",
+ .cra_blocksize = MD5_HMAC_BLOCK_SIZE,
+ .cra_module = THIS_MODULE,
}
};