diff options
| author | Tejun Heo <htejun@gmail.com> | 2007-07-16 14:29:40 +0900 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-07-20 08:26:25 -0400 |
| commit | 1ae463171cc1b1ea6dad7bcb298e96c073e7373e (patch) | |
| tree | c3d62562c9be8c855f7238785ea9c9348f1e56f1 /drivers/ata/libata.h | |
| parent | f1545154a5c96590b1992aac8ee1e2c445e301ed (diff) | |
| download | linux-1ae463171cc1b1ea6dad7bcb298e96c073e7373e.tar.gz linux-1ae463171cc1b1ea6dad7bcb298e96c073e7373e.tar.bz2 linux-1ae463171cc1b1ea6dad7bcb298e96c073e7373e.zip | |
libata: improve SCSI scan failure handling
SCSI scan may fail due to memory allocation failure even if EH is not
in progress. Due to use of GFP_ATOMIC in SCSI scan path, allocation
failure isn't too rare especially while probing multiple devices at
once which is the case when a bunch of devices are connected to PMP.
This patch moves SCSI scan failure detetion logic from
ata_scsi_hotplug() to ata_scsi_scan_host() and implement synchronous
scan behavior. The synchronous path sleeps briefly and repeats SCSI
scan if some devices aren't attached properly. It contains robust
retry loop to minimize the chance of device misdetection during boot
and falls back to async retry if everything fails.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/libata.h')
| -rw-r--r-- | drivers/ata/libata.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h index ba17fc5f2e99..48836b22ce2f 100644 --- a/drivers/ata/libata.h +++ b/drivers/ata/libata.h @@ -112,7 +112,7 @@ static inline int ata_acpi_on_devcfg(struct ata_device *adev) { return 0; } /* libata-scsi.c */ extern int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht); -extern void ata_scsi_scan_host(struct ata_port *ap); +extern void ata_scsi_scan_host(struct ata_port *ap, int sync); extern int ata_scsi_offline_dev(struct ata_device *dev); extern void ata_scsi_hotplug(struct work_struct *work); extern unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf, |