summaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-03-09 20:21:53 +0900
committerJeff Garzik <jeff@garzik.org>2008-03-10 20:51:05 -0400
commit7afb42226a8eaa9ae3f6b9917ffb16902358e749 (patch)
treec5f75a6297cdb6d4f7e753a2a7849bcb8d1f6237 /drivers/ata
parent70d562cf7853ea1bb53c1007075c5df958f11c90 (diff)
downloadlinux-7afb42226a8eaa9ae3f6b9917ffb16902358e749.tar.gz
linux-7afb42226a8eaa9ae3f6b9917ffb16902358e749.tar.bz2
linux-7afb42226a8eaa9ae3f6b9917ffb16902358e749.zip
libata: don't allow sysfs read access to force param
Buffer for force param is deallocated after initialization, so trying to read it via sysfs results in oops. Don't allow read access to the param node. Spotted by Eric Sesterhenn. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/libata-core.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 5310513b7573..4bbe31f98ef8 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -106,7 +106,8 @@ static struct ata_force_ent *ata_force_tbl;
static int ata_force_tbl_size;
static char ata_force_param_buf[PAGE_SIZE] __initdata;
-module_param_string(force, ata_force_param_buf, sizeof(ata_force_param_buf), 0444);
+/* param_buf is thrown away after initialization, disallow read */
+module_param_string(force, ata_force_param_buf, sizeof(ata_force_param_buf), 0);
MODULE_PARM_DESC(force, "Force ATA configurations including cable type, link speed and transfer mode (see Documentation/kernel-parameters.txt for details)");
int atapi_enabled = 1;