summaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-05-31 14:26:26 -0400
committerTejun Heo <tj@kernel.org>2017-05-31 14:26:26 -0400
commitf7cf69ae171592d133c69b9adaa5de7cfb6038ea (patch)
treee5e5d63c1db7ffd50dafd1f55c691842a79aae2d /drivers/ata
parent3e4240da0e3673637c1c995bdd14cfdbc8f4dc4c (diff)
downloadlinux-f7cf69ae171592d133c69b9adaa5de7cfb6038ea.tar.gz
linux-f7cf69ae171592d133c69b9adaa5de7cfb6038ea.tar.bz2
linux-f7cf69ae171592d133c69b9adaa5de7cfb6038ea.zip
libata: fix error checking in in ata_parse_force_one()
ata_parse_force_one() was incorrectly comparing @p to @endp when it should have been comparing @id. The only consequence is that it may end up using an invalid port number in "libata.force" module param instead of rejecting it. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Petru-Florin Mihancea <petrum@gmail.com> Link: https://bugzilla.kernel.org/show_bug.cgi?id=195785
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/libata-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2d83b8c75965..e157a0e44419 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6800,7 +6800,7 @@ static int __init ata_parse_force_one(char **cur,
}
force_ent->port = simple_strtoul(id, &endp, 10);
- if (p == endp || *endp != '\0') {
+ if (id == endp || *endp != '\0') {
*reason = "invalid port/link";
return -EINVAL;
}