diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2019-03-28 16:22:18 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-04-01 15:11:41 +0700 |
| commit | 8293488205f145aeefbec76f231303c8e32647a2 (patch) | |
| tree | 4a7925c5a5bf593a6c381d856c75d888f0430626 /drivers/base | |
| parent | 435bba0f11f06789be59757719c161915e92f889 (diff) | |
| download | linux-8293488205f145aeefbec76f231303c8e32647a2.tar.gz linux-8293488205f145aeefbec76f231303c8e32647a2.tar.bz2 linux-8293488205f145aeefbec76f231303c8e32647a2.zip | |
regmap: regmap-irq: fix getting type default values
Checking for value of type default value just after allocating will
always be zero and the type register default values will never be read,
so fix this!
Without this patch setting irq type will be silently ignored.
Patch "regmap: regmap-irq: Remove default irq type setting from core"
did remove the default mask but it forgot to remove the check before
reading the default type register.
Fixes: 84267d1b18ab ("regmap: regmap-irq: Remove default irq type setting from core")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/regmap/regmap-irq.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index 1bd1145ad8b5..b476918c5e50 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -664,9 +664,6 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags, if (chip->num_type_reg && !chip->type_in_mask) { for (i = 0; i < chip->num_type_reg; ++i) { - if (!d->type_buf_def[i]) - continue; - reg = chip->type_base + (i * map->reg_stride * d->type_reg_stride); |