diff options
| author | Lars Ellenberg <lars.ellenberg@linbit.com> | 2010-11-09 14:12:10 +0100 |
|---|---|---|
| committer | Philipp Reisner <philipp.reisner@linbit.com> | 2011-03-10 11:19:04 +0100 |
| commit | 18edc0b9d7dac2f74117a0bdb98f2e705eb74d82 (patch) | |
| tree | 046016ff1349564bbd77d94212e4689bd0af5390 /drivers/block/drbd/drbd_proc.c | |
| parent | 2649f0809f55e4df98c333a2b85c6fc8fee04804 (diff) | |
| download | linux-18edc0b9d7dac2f74117a0bdb98f2e705eb74d82.tar.gz linux-18edc0b9d7dac2f74117a0bdb98f2e705eb74d82.tar.bz2 linux-18edc0b9d7dac2f74117a0bdb98f2e705eb74d82.zip | |
drbd: fix potential wrap of 32bit oos:%lu display in /proc/drbd
When converting bits (4k resolution, still) to kB, we shift left. If it
was a large number of bits on a 32bit box (>= 4 TiB storage), we may
wrap the 32bit unsigned long base type, resulting in incorrect display.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_proc.c')
| -rw-r--r-- | drivers/block/drbd/drbd_proc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c index fab3fde3477b..07368b75392a 100644 --- a/drivers/block/drbd/drbd_proc.c +++ b/drivers/block/drbd/drbd_proc.c @@ -259,8 +259,9 @@ static int drbd_seq_show(struct seq_file *seq, void *v) mdev->epochs, write_ordering_chars[mdev->write_ordering] ); - seq_printf(seq, " oos:%lu\n", - Bit2KB(drbd_bm_total_weight(mdev))); + seq_printf(seq, " oos:%llu\n", + Bit2KB((unsigned long long) + drbd_bm_total_weight(mdev))); } if (mdev->state.conn == C_SYNC_SOURCE || mdev->state.conn == C_SYNC_TARGET || |