diff options
| author | Christoph Hellwig <hch@lst.de> | 2016-07-19 11:31:50 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-07-20 17:38:30 -0600 |
| commit | 0c4de0f33b0a86a426c0c3958cd40d8c82ede8d2 (patch) | |
| tree | d3666484b5a0f67400eacef1225826799390aa73 /drivers/block/virtio_blk.c | |
| parent | f9596695bee6a88d17118ee9f2f826f96b826644 (diff) | |
| download | linux-0c4de0f33b0a86a426c0c3958cd40d8c82ede8d2.tar.gz linux-0c4de0f33b0a86a426c0c3958cd40d8c82ede8d2.tar.bz2 linux-0c4de0f33b0a86a426c0c3958cd40d8c82ede8d2.zip | |
block: ensure bios return from blk_get_request are properly initialized
blk_get_request is used for BLOCK_PC and similar passthrough requests.
Currently we always need to call blk_rq_set_block_pc or an open coded
version of it to allow appending bios using the request mapping helpers
later on, which is a somewhat awkward API. Instead move the
initialization part of blk_rq_set_block_pc into blk_get_request, so that
we always have a safe to use request.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/virtio_blk.c')
| -rw-r--r-- | drivers/block/virtio_blk.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index a85a14355efa..1523e05c46fc 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -243,7 +243,6 @@ static int virtblk_get_id(struct gendisk *disk, char *id_str) req = blk_get_request(q, READ, GFP_KERNEL); if (IS_ERR(req)) return PTR_ERR(req); - blk_rq_set_block_pc(req); req->cmd_type = REQ_TYPE_DRV_PRIV; err = blk_rq_map_kern(q, req, id_str, VIRTIO_BLK_ID_BYTES, GFP_KERNEL); |