diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2021-12-24 10:53:18 +0800 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2022-01-06 14:52:11 +0100 |
| commit | b38cd3b42fba66cc538edb9cf77e07881f43f8e2 (patch) | |
| tree | ec34ec99fce69423eb2d2d75a43f1a031d6c8954 /drivers/bluetooth/hci_bcm.c | |
| parent | 710ad98c363a66a0cd8526465426c5c5f8377ee0 (diff) | |
| download | linux-b38cd3b42fba66cc538edb9cf77e07881f43f8e2.tar.gz linux-b38cd3b42fba66cc538edb9cf77e07881f43f8e2.tar.bz2 linux-b38cd3b42fba66cc538edb9cf77e07881f43f8e2.zip | |
Bluetooth: hci_bcm: Check for error irq
For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.
Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth/hci_bcm.c')
| -rw-r--r-- | drivers/bluetooth/hci_bcm.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 7852abf15ddf..d634a27bc850 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -1188,7 +1188,12 @@ static int bcm_probe(struct platform_device *pdev) return -ENOMEM; dev->dev = &pdev->dev; - dev->irq = platform_get_irq(pdev, 0); + + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + dev->irq = ret; /* Initialize routing field to an unused value */ dev->pcm_int_params[0] = 0xff; |