diff options
| author | Marek Vasut <marex@denx.de> | 2024-04-19 07:01:12 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2024-04-26 17:26:09 +0800 |
| commit | 31b57788a5024d3a114b28dad224a93831b90b5f (patch) | |
| tree | 3d59c0aca0e87ff3e96750058b467c9d80d0a7a8 /drivers/char/hw_random/stm32-rng.c | |
| parent | 01474b70a779319db6d3d2d67a7232a7b4202029 (diff) | |
| download | linux-31b57788a5024d3a114b28dad224a93831b90b5f.tar.gz linux-31b57788a5024d3a114b28dad224a93831b90b5f.tar.bz2 linux-31b57788a5024d3a114b28dad224a93831b90b5f.zip | |
hwrng: stm32 - use logical OR in conditional
The conditional is used to check whether err is non-zero OR whether
reg variable is non-zero after clearing bits from it. This should be
done using logical OR, not bitwise OR, fix it.
Fixes: 6b85a7e141cb ("hwrng: stm32 - implement STM32MP13x support")
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char/hw_random/stm32-rng.c')
| -rw-r--r-- | drivers/char/hw_random/stm32-rng.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 379bc245c520..1cc61ef8ee54 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -353,7 +353,7 @@ static int stm32_rng_init(struct hwrng *rng) err = readl_relaxed_poll_timeout_atomic(priv->base + RNG_SR, reg, reg & RNG_SR_DRDY, 10, 100000); - if (err | (reg & ~RNG_SR_DRDY)) { + if (err || (reg & ~RNG_SR_DRDY)) { clk_disable_unprepare(priv->clk); dev_err((struct device *)priv->rng.priv, "%s: timeout:%x SR: %x!\n", __func__, err, reg); |