diff options
| author | Peter Huewe <huewe.external.infineon@googlemail.com> | 2011-03-29 13:31:25 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-03-29 09:45:34 -0700 |
| commit | 1309d7afbed112f0e8e90be9af975550caa0076b (patch) | |
| tree | 750110269ee7a6d977494c5fb696af109ecb0aad /drivers/char | |
| parent | 0444d76ae64fffc7851797fc1b6ebdbb44ac504a (diff) | |
| download | linux-1309d7afbed112f0e8e90be9af975550caa0076b.tar.gz linux-1309d7afbed112f0e8e90be9af975550caa0076b.tar.bz2 linux-1309d7afbed112f0e8e90be9af975550caa0076b.zip | |
char/tpm: Fix unitialized usage of data buffer
This patch fixes information leakage to the userspace by initializing
the data buffer to zero.
Reported-by: Peter Huewe <huewe.external@infineon.com>
Signed-off-by: Peter Huewe <huewe.external@infineon.com>
Signed-off-by: Marcel Selhorst <m.selhorst@sirrix.com>
[ Also removed the silly "* sizeof(u8)". If that isn't 1, we have way
deeper problems than a simple multiplication can fix. - Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/tpm/tpm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c index 1f46f1cd9225..7beb0e25f1e1 100644 --- a/drivers/char/tpm/tpm.c +++ b/drivers/char/tpm/tpm.c @@ -980,7 +980,7 @@ int tpm_open(struct inode *inode, struct file *file) return -EBUSY; } - chip->data_buffer = kmalloc(TPM_BUFSIZE * sizeof(u8), GFP_KERNEL); + chip->data_buffer = kzalloc(TPM_BUFSIZE, GFP_KERNEL); if (chip->data_buffer == NULL) { clear_bit(0, &chip->is_open); put_device(chip->dev); |