summaryrefslogtreecommitdiffstats
path: root/drivers/clocksource
diff options
context:
space:
mode:
authorDaniel Lezcano <daniel.lezcano@linaro.org>2015-09-20 07:00:35 -0700
committerDaniel Lezcano <daniel.lezcano@linaro.org>2015-09-29 14:33:51 +0200
commitbdf7344e14d826d0df438a55fc51146d179e198d (patch)
treea4a14d18fac507cecb30e57769e073c0cf51f90a /drivers/clocksource
parentccc42592d436d021d17f86729d24806f30dbad25 (diff)
downloadlinux-bdf7344e14d826d0df438a55fc51146d179e198d.tar.gz
linux-bdf7344e14d826d0df438a55fc51146d179e198d.tar.bz2
linux-bdf7344e14d826d0df438a55fc51146d179e198d.zip
clocksource/drivers/keystone: Fix bad NO_IRQ usage
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case of failure. Unfortunately, the NO_IRQ is not consistent across the different architectures and we must not rely on it. NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case of an error. Hence, the latter won't be detected and will lead to a crash. Fix this by just checking 'irq' is different from zero. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Diffstat (limited to 'drivers/clocksource')
-rw-r--r--drivers/clocksource/timer-keystone.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clocksource/timer-keystone.c b/drivers/clocksource/timer-keystone.c
index edacf3902e10..1cea08cf603e 100644
--- a/drivers/clocksource/timer-keystone.c
+++ b/drivers/clocksource/timer-keystone.c
@@ -152,7 +152,7 @@ static void __init keystone_timer_init(struct device_node *np)
int irq, error;
irq = irq_of_parse_and_map(np, 0);
- if (irq == NO_IRQ) {
+ if (!irq) {
pr_err("%s: failed to map interrupts\n", __func__);
return;
}