diff options
| author | Tudor-Dan Ambarus <tudor.ambarus@microchip.com> | 2018-03-23 12:42:22 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2018-03-31 01:33:13 +0800 |
| commit | a664b4b140678d06825467a52885c0e8d46ac0ed (patch) | |
| tree | 37bf1316b9804f82ce323465d59a00ffcf489f0a /drivers/crypto/picoxcell_crypto.c | |
| parent | 0e7da29d6c31f897c544c1f7499389111225566f (diff) | |
| download | linux-a664b4b140678d06825467a52885c0e8d46ac0ed.tar.gz linux-a664b4b140678d06825467a52885c0e8d46ac0ed.tar.bz2 linux-a664b4b140678d06825467a52885c0e8d46ac0ed.zip | |
crypto: picoxcell - don't leak pointers to authenc keys
In spacc_aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/picoxcell_crypto.c')
| -rw-r--r-- | drivers/crypto/picoxcell_crypto.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c index 4ef52c9d72fc..a4df966adbf6 100644 --- a/drivers/crypto/picoxcell_crypto.c +++ b/drivers/crypto/picoxcell_crypto.c @@ -499,10 +499,12 @@ static int spacc_aead_setkey(struct crypto_aead *tfm, const u8 *key, memcpy(ctx->hash_ctx, keys.authkey, keys.authkeylen); ctx->hash_key_len = keys.authkeylen; + memzero_explicit(&keys, sizeof(keys)); return 0; badkey: crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); + memzero_explicit(&keys, sizeof(keys)); return -EINVAL; } |