summaryrefslogtreecommitdiffstats
path: root/drivers/crypto
diff options
context:
space:
mode:
authorTudor-Dan Ambarus <tudor.ambarus@microchip.com>2018-03-23 12:42:19 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2018-03-31 01:33:12 +0800
commitcc4ccaafcbddb88d661143c779af08d4ed8798ae (patch)
treea87700ae3612c4e3c7de2ff00dfae9d3fb34d4a0 /drivers/crypto
parent61dab9726050b0ffa826f1b540e9518768914b76 (diff)
downloadlinux-cc4ccaafcbddb88d661143c779af08d4ed8798ae.tar.gz
linux-cc4ccaafcbddb88d661143c779af08d4ed8798ae.tar.bz2
linux-cc4ccaafcbddb88d661143c779af08d4ed8798ae.zip
crypto: caam/qi - don't leak pointers to authenc keys
In caam/qi's aead_setkey we save pointers to the authenc keys in a local variable of type struct crypto_authenc_keys and we don't zeroize it after use. Fix this and don't leak pointers to the authenc keys. Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r--drivers/crypto/caam/caamalg_qi.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/crypto/caam/caamalg_qi.c b/drivers/crypto/caam/caamalg_qi.c
index c2b5762d56a0..cacda0831390 100644
--- a/drivers/crypto/caam/caamalg_qi.c
+++ b/drivers/crypto/caam/caamalg_qi.c
@@ -278,9 +278,11 @@ skip_split_key:
}
}
+ memzero_explicit(&keys, sizeof(keys));
return ret;
badkey:
crypto_aead_set_flags(aead, CRYPTO_TFM_RES_BAD_KEY_LEN);
+ memzero_explicit(&keys, sizeof(keys));
return -EINVAL;
}