diff options
| author | Nicolas Ferre <nicolas.ferre@atmel.com> | 2011-04-30 16:57:48 +0200 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2011-05-02 15:42:09 +0530 |
| commit | 2f432823ec6e693d7b934e805ce1838f41d66ce7 (patch) | |
| tree | d3081ac9ae558e05b18f9df49a9c127bf8dc45de /drivers/dma/at_hdmac.c | |
| parent | cc52a10a048fc1fbe4ffba58c2f0afc79ae0f56f (diff) | |
| download | linux-2f432823ec6e693d7b934e805ce1838f41d66ce7.tar.gz linux-2f432823ec6e693d7b934e805ce1838f41d66ce7.tar.bz2 linux-2f432823ec6e693d7b934e805ce1838f41d66ce7.zip | |
dmaengine: at_hdmac: remove channel status testing in tasklet
There is no need to test if channel is enabled in tasklet:
- in error path, channel is disabled in interrupt routine
- in normal path, this test is performed in sub functions to report
a misuse of the engine.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/at_hdmac.c')
| -rw-r--r-- | drivers/dma/at_hdmac.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 8f50a0fb79e7..65bd52a84bc3 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -472,13 +472,6 @@ static void atc_tasklet(unsigned long data) { struct at_dma_chan *atchan = (struct at_dma_chan *)data; - /* Channel cannot be enabled here */ - if (atc_chan_is_enabled(atchan)) { - dev_err(chan2dev(&atchan->chan_common), - "BUG: channel enabled in tasklet\n"); - return; - } - spin_lock(&atchan->lock); if (test_and_clear_bit(ATC_IS_ERROR, &atchan->status)) atc_handle_error(atchan); |