summaryrefslogtreecommitdiffstats
path: root/drivers/dma/at_xdmac.c
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2015-11-21 12:09:47 +0100
committerVinod Koul <vinod.koul@intel.com>2015-12-05 15:56:27 +0530
commit1f281792f649fc40054fc9146d8aa6b8b3c2aaff (patch)
treef16f04d16f3c6105490fef741052cb1863ab7407 /drivers/dma/at_xdmac.c
parent82d149b86d31e11fbbbc1b850bebffe1bfa2e82d (diff)
downloadlinux-1f281792f649fc40054fc9146d8aa6b8b3c2aaff.tar.gz
linux-1f281792f649fc40054fc9146d8aa6b8b3c2aaff.tar.bz2
linux-1f281792f649fc40054fc9146d8aa6b8b3c2aaff.zip
dmaengine: at_xdmac: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one hand the IRQ can easily fire again before free_irq() is entered, on the other hand free_irq() itself calls synchronize_irq() internally (in a race condition free way), before any state associated with the IRQ is freed. Patch was generated using the following semantic patch: // <smpl> @@ expression irq; @@ -synchronize_irq(irq); free_irq(irq, ...); // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/at_xdmac.c')
-rw-r--r--drivers/dma/at_xdmac.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index f2b6e7d22765..d0ae4613b87e 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -2007,8 +2007,6 @@ static int at_xdmac_remove(struct platform_device *pdev)
dma_async_device_unregister(&atxdmac->dma);
clk_disable_unprepare(atxdmac->clk);
- synchronize_irq(atxdmac->irq);
-
free_irq(atxdmac->irq, atxdmac->dma.dev);
for (i = 0; i < atxdmac->dma.chancnt; i++) {